Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add examples of entire pages to Storybook #1234

Merged
merged 41 commits into from
Jun 21, 2024

Conversation

dlnr
Copy link
Contributor

@dlnr dlnr commented May 17, 2024

For your consideration, some example page patterns. This is a very quick and developer friendly way to create full pages in Storybook, you can reuse stories (see Article story) or completely static (Homepage story is a copy of prototypes).

There are added benefits like a11y tests for the full page, interactions tests for forms, quick theme switching, viewports etc.

Also, we don't have to maintain another app like prototypes. We should do a prototypes pages more like a started kit because developers will use it as such.

I've not included the pages in a Canvas block but instead created an example codeblock with some pseudo page layout code. The idea is to elaborate on page structure and leave the pages to fullscreen examples.

@github-actions github-actions bot temporarily deployed to demo-storybook-patterns May 17, 2024 14:29 Destroyed
@github-actions github-actions bot temporarily deployed to demo-storybook-patterns May 17, 2024 14:31 Destroyed
@github-actions github-actions bot temporarily deployed to demo-storybook-patterns May 17, 2024 15:50 Destroyed
@VincentSmedinga VincentSmedinga self-assigned this Jun 6, 2024
@github-actions github-actions bot temporarily deployed to demo-storybook-patterns June 6, 2024 11:14 Destroyed
@github-actions github-actions bot temporarily deployed to demo-storybook-patterns June 6, 2024 15:18 Destroyed
@VincentSmedinga VincentSmedinga changed the title feat: Storybook page patterns feat: Add new section to Storybook for example pages Jun 6, 2024
@github-actions github-actions bot temporarily deployed to demo-storybook-patterns June 13, 2024 07:32 Destroyed
@github-actions github-actions bot temporarily deployed to demo-storybook-patterns June 13, 2024 08:40 Destroyed
@dlnr dlnr requested a review from VincentSmedinga June 14, 2024 10:05
@github-actions github-actions bot temporarily deployed to demo-storybook-patterns June 14, 2024 14:33 Destroyed
packages/react/src/PageMenu/PageMenu.test.tsx Show resolved Hide resolved
packages/react/src/PageMenu/PageMenu.test.tsx Show resolved Hide resolved
storybook/src/components/Footer/Footer.stories.tsx Outdated Show resolved Hide resolved
storybook/src/components/Heading/Heading.stories.tsx Outdated Show resolved Hide resolved
storybook/src/components/Image/Image.stories.tsx Outdated Show resolved Hide resolved
storybook/src/pages/amsterdam/article/ArticleHeader.tsx Outdated Show resolved Hide resolved
storybook/src/pages/amsterdam/article/ArticleBody.tsx Outdated Show resolved Hide resolved
storybook/src/pages/amsterdam/home/Home.tsx Outdated Show resolved Hide resolved
storybook/src/pages/amsterdam/home/Home.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to demo-storybook-patterns June 19, 2024 12:05 Destroyed
@VincentSmedinga VincentSmedinga requested a review from alimpens June 19, 2024 13:20
@github-actions github-actions bot temporarily deployed to demo-storybook-patterns June 21, 2024 12:08 Destroyed
@VincentSmedinga VincentSmedinga merged commit e5f8d58 into develop Jun 21, 2024
4 checks passed
@VincentSmedinga VincentSmedinga deleted the feature/storybook-patterns branch June 21, 2024 12:11
@github-actions github-actions bot mentioned this pull request Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants